Add get missing metadata contracts task #58
+83
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
changed the title
Pull Request Test Coverage Report for Build 12694200882Details
💛 - Coveralls |
falvaradorodriguez
approved these changes
Jan 10, 2025
| @@ -281,15 +281,20 @@ async def get_abi_by_contract_address( | |||
| return None | |||
|
|
|||
| @classmethod | |||
| async def get_contracts_without_abi(cls, session: AsyncSession): | |||
| async def get_contracts_without_abi(cls, session: AsyncSession, max_retries: int): | |||
There was a problem hiding this comment.
IMO max_retries parameter should be optional and takes 0 as default value. WDYT?
| ) -> None: | ||
| contract_metadata_service = get_contract_metadata_service() | ||
| # Just try the first time, following retries should be scheduled | ||
| if await contract_metadata_service.should_attempt_download( | ||
| if skip_attemp_download or await contract_metadata_service.should_attempt_download( |
There was a problem hiding this comment.
Nitpicky: contract_metadata_service.should_attempt_download conditional can be in a separate variable. It would be more understandable in the future. The comment only affects the second part of the condition
moisses89
commented
Jan 10, 2025
| @@ -61,3 +66,16 @@ async def get_contract_metadata_task( | |||
| ) | |||
| else: | |||
| logging.debug(f"Skipping contract with address {address} and chain {chain_id}") | |||
|
|
|||
|
|
|||
| @dramatiq.actor(periodic=cron("* * * * *")) # Every midnight | |||
There was a problem hiding this comment.
Would be every midnight not every day.
There was a problem hiding this comment.
* * * * * means every minute, right?
| @@ -61,3 +66,16 @@ async def get_contract_metadata_task( | |||
| ) | |||
| else: | |||
| logging.debug(f"Skipping contract with address {address} and chain {chain_id}") | |||
|
|
|||
|
|
|||
| @dramatiq.actor(periodic=cron("* * * * *")) # Every midnight | |||
There was a problem hiding this comment.
Suggested change
| @dramatiq.actor(periodic=cron("* * * * *")) # Every midnight | |
| @dramatiq.actor(periodic=cron("0 0 * * *")) # Every midnight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52